This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't check ABI for _nl_default_dirname


> Does that make sense?

Not for _nl_default_dirname at least. The whole concept of an API
that depends on the prefix is obviously broken.

As far as I can tell noone should rely on that array size anyways, it's simply
a bug in the ABI checker that it checks it. I provided a reasonable
solution and you want a overengineered pony instead.

The part that also seems wrong to me is that you guys don't seem 
to care whether your test suite is reliable or not. It's great
that glibc has a test suite, but any borken test in the test suite
makes it far less useful and less trustworthy.  The highest priority
for any of these is to disable them, so that people can get the test
coverage for the non broken tests.  

Any value that this test may have is far outweighted by the developer
productivity damage of a fragile test suite.

Of course since this check checks the whole ABI that's not a good idea
to disable it completely, but just disable for the symbol where it's broken
is imho a reaonable strategy.

The test suite already needs various undocumented magic incarnations
to work (copy libstdc++ and libgcc). If I had to provide manual
overrides for symbols like this it would be even worse and I have
no idea how some newbie developer would ever learn to do that.
(and no the fix is not to write more docs, the fix is to make check
reliable by itself)

It's even worse than with gcc which also has a unreliable test suite,
but at least you're expected there to use -k and check it manually.
But with glibc it would nearly work to trust it, except for that
single broken check and it doesn't have the reporting
tools to make -k work well.

And the suggestion to wait for 2.18 was completely impractical. I need
a passing test suite right now, not with 2.18.

I'll keep the patch for now for my private builds.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]