This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: "Carlos O'Donell" <carlos at systemhalted dot org>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 10 Dec 2012 10:35:27 +0530
Subject: Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"
References: <20121210010033.GA8607@gmail.com><CAE2sS1j+DOomvGsEK-ZJur5tZOpHvpbz=rSkNezvOqa+RDYqbw@mail.gmail.com>

> Could you please explain how this is different than just deleting the symbol?
> 
> Your changes make the test for this particular symbol a tautology.
> 
> You check to see that the size is the size you set which is always true.
> 
> The check you want is to see if the size you set matches the expected ABI size.
> 

In case of a prefix + a constant in a data symbol, the latter should
be unchanging from the viewpoint of glibc, while the former is the
responsibility of the distribution.  IMO, trying to check if some
prefix is a pre-computed value is not a sensible ABI check from the
glibc point of view.

Follow-Ups:
- Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"
  - From: David Miller

References:
- PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"
  - From: H.J. Lu
- Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]