This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix potential access beyond array bounds in m1np

From: Andreas Schwab <schwab at linux-m68k dot org>
To: Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: Andreas Jaeger <aj at suse dot com>, libc-alpha at sourceware dot org
Date: Fri, 28 Dec 2012 15:19:05 +0100
Subject: Re: [PATCH] Fix potential access beyond array bounds in m1np
References: <20121228120511.GC25030@spoyarek.pnq.redhat.com><50DD913B.9070908@suse.com><20121228130043.GD25030@spoyarek.pnq.redhat.com>

Siddhesh Poyarekar <siddhesh@redhat.com> writes:

> +  if (__glibc_unlikely (p < 18 && (m=m1+m2) <= 0)) {

m remains uninitialized if p >= 18.  The assignment should be moved out
of the condition anyway.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- [PATCH v3] Fix potential access beyond array bounds in m1np
  - From: Siddhesh Poyarekar

References:
- [PATCH] Fix potential access beyond array bounds in m1np
  - From: Siddhesh Poyarekar
- Re: [PATCH] Fix potential access beyond array bounds in m1np
  - From: Andreas Jaeger
- Re: [PATCH] Fix potential access beyond array bounds in m1np
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]