Re: [PATCH] Remove commented functions from mpa.c

[Andreas Jaeger <aj at suse dot com>]

On 01/04/2013 11:07 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> These functions seem to have been commented since forever and are
> unused.  Is it OK to remove them?
>
> Siddhesh
>
> ChangeLog:
>
> 	* sysdeps/ieee754/dbl-64/mpa.c (__cr): Remove.
> 	(__cpymn): Likewise.

Please check the PowerPC versions of mpa.c as well for usage and 
implementation and send a combined patch.

thanks,
Andreas

> diff --git a/sysdeps/ieee754/dbl-64/mpa.c b/sysdeps/ieee754/dbl-64/mpa.c
> index 0db1386..b0571f9 100644
> --- a/sysdeps/ieee754/dbl-64/mpa.c
> +++ b/sysdeps/ieee754/dbl-64/mpa.c
> @@ -93,21 +93,6 @@ __acr(const mp_no *x, const mp_no *y, int p) {
>   #endif
>
>
> -#if 0
> -/* cr() compares the values of two multiple precision numbers           */
> -static int  __cr(const mp_no *x, const mp_no *y, int p) {
> -  int i;
> -
> -  if      (X[0] > Y[0])  i= 1;
> -  else if (X[0] < Y[0])  i=-1;
> -  else if (X[0] < ZERO ) i= __acr(y,x,p);
> -  else                   i= __acr(x,y,p);
> -
> -  return i;
> -}
> -#endif
> -
> -
>   #ifndef NO___CPY
>   /* Copy a multiple precision number. Set *y=*x. x=y is permissible.      */
>   void __cpy(const mp_no *x, mp_no *y, int p) {
> @@ -117,24 +102,6 @@ void __cpy(const mp_no *x, mp_no *y, int p) {
>   #endif
>
>
> -#if 0
> -/* Copy a multiple precision number x of precision m into a */
> -/* multiple precision number y of precision n. In case n>m, */
> -/* the digits of y beyond the m'th are set to zero. In case */
> -/* n<m, the digits of x beyond the n'th are ignored.        */
> -/* x=y is permissible.                                      */
> -
> -static void __cpymn(const mp_no *x, int m, mp_no *y, int n) {
> -
> -  int i,k;
> -
> -  EY = EX;     k=MIN(m,n);
> -  for (i=0; i <= k; i++)    Y[i] = X[i];
> -  for (   ; i <= n; i++)    Y[i] = ZERO;
> -}
> -#endif
> -
> -
>   #ifndef NO___MP_DBL
>   /* Convert a multiple precision number *x into a double precision */
>   /* number *y, normalized case  (|x| >= 2**(-1022))) */


--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126