This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove commented functions from mpa.c


On Fri, Jan 04, 2013 at 11:34:00AM +0100, Andreas Jaeger wrote:
> Let's keep them in sync as far as possible.
> 

OK, here's the patch then - I've also removed the commented out code
in the powerpc versions to match the global mpa.c.  OK to commit on
Monday if Ryan/Steven don't have a problem with it?

Siddhesh

	* sysdeps/ieee754/dbl-64/mpa.c: Remove commented code.
	* sysdeps/powerpc/powerpc32/power4/fpu/mpa.c (__cr): Remove.
	(__cpymn): Likewise.
	(norm): Remove commented code.
	(denorm): Likewise.
	(__mp_dbl): Likewise.
	(__inv): Likewise.
	* sysdeps/powerpc/powerpc64/power4/fpu/mpa.c (__cr): Remove.
	(__cpymn): Likewise.
	(norm): Remove commented code.
	(denorm): Likewise.
	(__mp_dbl): Likewise.
	(__inv): Likewise.

diff --git a/sysdeps/ieee754/dbl-64/mpa.c b/sysdeps/ieee754/dbl-64/mpa.c
index 0db1386..b0571f9 100644
--- a/sysdeps/ieee754/dbl-64/mpa.c
+++ b/sysdeps/ieee754/dbl-64/mpa.c
@@ -93,21 +93,6 @@ __acr(const mp_no *x, const mp_no *y, int p) {
 #endif
 
 
-#if 0
-/* cr() compares the values of two multiple precision numbers           */
-static int  __cr(const mp_no *x, const mp_no *y, int p) {
-  int i;
-
-  if      (X[0] > Y[0])  i= 1;
-  else if (X[0] < Y[0])  i=-1;
-  else if (X[0] < ZERO ) i= __acr(y,x,p);
-  else                   i= __acr(x,y,p);
-
-  return i;
-}
-#endif
-
-
 #ifndef NO___CPY
 /* Copy a multiple precision number. Set *y=*x. x=y is permissible.      */
 void __cpy(const mp_no *x, mp_no *y, int p) {
@@ -117,24 +102,6 @@ void __cpy(const mp_no *x, mp_no *y, int p) {
 #endif
 
 
-#if 0
-/* Copy a multiple precision number x of precision m into a */
-/* multiple precision number y of precision n. In case n>m, */
-/* the digits of y beyond the m'th are set to zero. In case */
-/* n<m, the digits of x beyond the n'th are ignored.        */
-/* x=y is permissible.                                      */
-
-static void __cpymn(const mp_no *x, int m, mp_no *y, int n) {
-
-  int i,k;
-
-  EY = EX;     k=MIN(m,n);
-  for (i=0; i <= k; i++)    Y[i] = X[i];
-  for (   ; i <= n; i++)    Y[i] = ZERO;
-}
-#endif
-
-
 #ifndef NO___MP_DBL
 /* Convert a multiple precision number *x into a double precision */
 /* number *y, normalized case  (|x| >= 2**(-1022))) */
diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/mpa.c b/sysdeps/powerpc/powerpc32/power4/fpu/mpa.c
index 7635a60..449a745 100644
--- a/sysdeps/powerpc/powerpc32/power4/fpu/mpa.c
+++ b/sysdeps/powerpc/powerpc32/power4/fpu/mpa.c
@@ -82,19 +82,6 @@ int __acr(const mp_no *x, const mp_no *y, int p) {
 }
 
 
-/* cr90 compares the values of two multiple precision numbers           */
-int  __cr(const mp_no *x, const mp_no *y, int p) {
-  int i;
-
-  if      (X[0] > Y[0])  i= 1;
-  else if (X[0] < Y[0])  i=-1;
-  else if (X[0] < ZERO ) i= __acr(y,x,p);
-  else                   i= __acr(x,y,p);
-
-  return i;
-}
-
-
 /* Copy a multiple precision number. Set *y=*x. x=y is permissible.      */
 void __cpy(const mp_no *x, mp_no *y, int p) {
   long i;
@@ -106,34 +93,12 @@ void __cpy(const mp_no *x, mp_no *y, int p) {
 }
 
 
-/* Copy a multiple precision number x of precision m into a */
-/* multiple precision number y of precision n. In case n>m, */
-/* the digits of y beyond the m'th are set to zero. In case */
-/* n<m, the digits of x beyond the n'th are ignored.        */
-/* x=y is permissible.                                      */
-
-void __cpymn(const mp_no *x, int m, mp_no *y, int n) {
-
-  long i,k;
-  long n2 = n;
-  long m2 = m;
-
-  EY = EX;     k=MIN(m2,n2);
-  for (i=0; i <= k; i++)    Y[i] = X[i];
-  for (   ; i <= n2; i++)    Y[i] = ZERO;
-
-  return;
-}
-
 /* Convert a multiple precision number *x into a double precision */
 /* number *y, normalized case  (|x| >= 2**(-1022))) */
 static void norm(const mp_no *x, double *y, int p)
 {
   #define R  radixi.d
   long i;
-#if 0
-  int k;
-#endif
   double a,c,u,v,z[5];
   if (p<5) {
     if      (p==1) c = X[1];
@@ -187,9 +152,6 @@ static void denorm(const mp_no *x, double *y, int p)
   long i,k;
   long p2 = p;
   double c,u,z[5];
-#if 0
-  double a,v;
-#endif
 
 #define R  radixi.d
   if (EX<-44 || (EX==-44 && X[1]<TWO5))
@@ -234,10 +196,6 @@ static void denorm(const mp_no *x, double *y, int p)
 /* The result is correctly rounded to the nearest/even. *x is left unchanged */
 
 void __mp_dbl(const mp_no *x, double *y, int p) {
-#if 0
-  int i,k;
-  double a,c,u,v,z[5];
-#endif
 
   if (X[0] == ZERO)  {*y = ZERO;  return; }
 
@@ -508,9 +466,6 @@ void __mul(const mp_no *x, const mp_no *y, mp_no *z, int p) {
 
 void __inv(const mp_no *x, mp_no *y, int p) {
   long i;
-#if 0
-  int l;
-#endif
   double t;
   mp_no z,w;
   static const int np1[] = {0,0,0,0,1,2,2,2,2,3,3,3,3,3,3,3,3,3,
diff --git a/sysdeps/powerpc/powerpc64/power4/fpu/mpa.c b/sysdeps/powerpc/powerpc64/power4/fpu/mpa.c
index 7635a60..449a745 100644
--- a/sysdeps/powerpc/powerpc64/power4/fpu/mpa.c
+++ b/sysdeps/powerpc/powerpc64/power4/fpu/mpa.c
@@ -82,19 +82,6 @@ int __acr(const mp_no *x, const mp_no *y, int p) {
 }
 
 
-/* cr90 compares the values of two multiple precision numbers           */
-int  __cr(const mp_no *x, const mp_no *y, int p) {
-  int i;
-
-  if      (X[0] > Y[0])  i= 1;
-  else if (X[0] < Y[0])  i=-1;
-  else if (X[0] < ZERO ) i= __acr(y,x,p);
-  else                   i= __acr(x,y,p);
-
-  return i;
-}
-
-
 /* Copy a multiple precision number. Set *y=*x. x=y is permissible.      */
 void __cpy(const mp_no *x, mp_no *y, int p) {
   long i;
@@ -106,34 +93,12 @@ void __cpy(const mp_no *x, mp_no *y, int p) {
 }
 
 
-/* Copy a multiple precision number x of precision m into a */
-/* multiple precision number y of precision n. In case n>m, */
-/* the digits of y beyond the m'th are set to zero. In case */
-/* n<m, the digits of x beyond the n'th are ignored.        */
-/* x=y is permissible.                                      */
-
-void __cpymn(const mp_no *x, int m, mp_no *y, int n) {
-
-  long i,k;
-  long n2 = n;
-  long m2 = m;
-
-  EY = EX;     k=MIN(m2,n2);
-  for (i=0; i <= k; i++)    Y[i] = X[i];
-  for (   ; i <= n2; i++)    Y[i] = ZERO;
-
-  return;
-}
-
 /* Convert a multiple precision number *x into a double precision */
 /* number *y, normalized case  (|x| >= 2**(-1022))) */
 static void norm(const mp_no *x, double *y, int p)
 {
   #define R  radixi.d
   long i;
-#if 0
-  int k;
-#endif
   double a,c,u,v,z[5];
   if (p<5) {
     if      (p==1) c = X[1];
@@ -187,9 +152,6 @@ static void denorm(const mp_no *x, double *y, int p)
   long i,k;
   long p2 = p;
   double c,u,z[5];
-#if 0
-  double a,v;
-#endif
 
 #define R  radixi.d
   if (EX<-44 || (EX==-44 && X[1]<TWO5))
@@ -234,10 +196,6 @@ static void denorm(const mp_no *x, double *y, int p)
 /* The result is correctly rounded to the nearest/even. *x is left unchanged */
 
 void __mp_dbl(const mp_no *x, double *y, int p) {
-#if 0
-  int i,k;
-  double a,c,u,v,z[5];
-#endif
 
   if (X[0] == ZERO)  {*y = ZERO;  return; }
 
@@ -508,9 +466,6 @@ void __mul(const mp_no *x, const mp_no *y, mp_no *z, int p) {
 
 void __inv(const mp_no *x, mp_no *y, int p) {
   long i;
-#if 0
-  int l;
-#endif
   double t;
   mp_no z,w;
   static const int np1[] = {0,0,0,0,1,2,2,2,2,3,3,3,3,3,3,3,3,3,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]