Re: [PATCH] Add finit_module syscall for Linux

[Kees Cook <keescook at chromium dot org>]

On Tue, Jan 22, 2013 at 8:04 PM, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Jan 22, 2013 at 7:16 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
>> On Tue, 22 Jan 2013, Kees Cook wrote:
>>
>>> This adds the new Linux finit_module() syscall.
>>
>> There's no point in adding syscalls to syscalls.list without at least
>> adding a symbol version so the function is actually exported from libc.so.
>> Note that in the kexec_load discussion last May / June, doubts were
>> expressed about whether some existing module-related syscalls really
>> should have had functions in glibc.
>
> Hm, okay. I tried to find some good examples, but the git history on
> syscalls.list made it difficult. There doesn't seem to be anything
> special done for init_module(), so I guess I'm confused what's needed
> here for finit_module(). I'll go see if the kexec_load discussion will
> shed the light I need. :)

Ah-ha. I think I see what I missed. It looks like I need to add it to
the arch-specific .ablist files as well as the Versions file? I was
hoping to avoid the arch-specific stuff, since it should be available
on any arch that hooks it up.

-Kees

--
Kees Cook
Chrome OS Security