This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
On 02/25/2013 09:13 PM, Siddhesh Poyarekar wrote:
> -#ifdef __GNUC__
> -# define __attribute(arg) __attribute__ (arg)
> -#else
> -# define __attribute(arg)
> -#endif
When merging this into gnulib I noticed the above change will
cause problems outside libc, since later code assumes that
__attribute__((xxx)) will work and this isn't true with non-GCC
compilers, or with ancient GCC. Could you please replace the above
code with the following, instead of deleting it?
#if __GNUC__ < 3 + (__GNUC_MINOR__ < 1)
# define __attribute__(arg)
#endif
That's what I did here, in the merge to gnulib:
http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=930b85b8881f5a65e5b99b75e7341a01ddc2c766
Thanks.
- References:
- [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c,bug-regex33.c