This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
On 02/25/2013 11:36 PM, Siddhesh Poyarekar wrote:
> the check above doesn't seem right though; maybe it should be like below
> instead to define __attribute__ if the compiler is not gcc or is a gcc
> version less than 3.
The idea is to define __attribute__ to be a no-op for GCC versions before
3.1. The code I sent you does that; the code you sent me changes at 3.0, not
3.1. For non-GCC compilers, __GNUC__ evaluates to 0 in an #if.
At this point I expect nobody uses GCC 3.0 any more so the distinction
may be a who-cares now.
- References:
- [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c,bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c, bug-regex33.c
- Re: [PATCH] Fix build warnings in regex.c, bug-regex20.c,bug-regex33.c