This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Cleanup: don't call free(NULL) unnecessarily

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
Cc: libc-alpha at sourceware dot org, ahh at google dot com
Date: Tue, 5 Mar 2013 19:29:31 -0800
Subject: Re: [patch] Cleanup: don't call free(NULL) unnecessarily
References: <ye6qehft7j12.fsf@elbrus2.mtv.corp.google.com> <CAAHN_R0Uvg9hJ_RGgDjJYmsCsTS0Na5NTcfj7TRB3JdGPKnvKQ@mail.gmail.com>

On Tue, Mar 5, 2013 at 7:18 PM, Siddhesh Poyarekar
<siddhesh.poyarekar@gmail.com> wrote:
> On 6 March 2013 00:48, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>> +    if (__builtin_expect (workstart != NULL, 0))
>> +      free (workstart);
>
> Sorry, I'm a little late on this, but this should have been
> __glibc_unlikely() instead of __builtin_expect.

Thanks. Should I clean up other instances of __builtin_expect in the
same file as well?


-- 
Paul Pluzhnikov

Follow-Ups:
- Re: [patch] Cleanup: don't call free(NULL) unnecessarily
  - From: Siddhesh Poyarekar

References:
- [patch] Cleanup: don't call free(NULL) unnecessarily
  - From: Paul Pluzhnikov
- Re: [patch] Cleanup: don't call free(NULL) unnecessarily
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]