This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove Prefer_SSE_for_memop on x64
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 07 Mar 2013 10:12:27 +0100
- Subject: Re: [PATCH] Remove Prefer_SSE_for_memop on x64
- References: <20130214213001.GA11656@domone.kolej.mff.cuni.cz>
On 02/14/2013 10:30 PM, OndÅej BÃlka wrote:
Hello,
As I asked in
http://www.sourceware.org/ml/libc-alpha/2013-02/msg00203.html
nobody objected to keep non-sse memset on x64.
This patch removes that implementation and flag Prefer_SSE_for_memop
which is always set and only choose sse memset over nonsse one.
2013-02-14 OndÅej BÃlka <neleai@seznam.cz>
* sysdeps/x86_64/memset.S: Always define bcopy.
I suggest:
Remove USE_MULTIARCH conditional for definining bcopy.
* sysdeps/x86_64/multiarch/Makefile: Update.
Which variable are you changing - and how?
* sysdeps/x86_64/multiarch/ifunc-impl-list.c: Update.
* sysdeps/x86_64/multiarch/init-arch.c: Remove Prefer_SSE_for_memop.
The two entries above miss the function changed. Replace Update with a
proper description.
* sysdeps/x86_64/multiarch/init-arch.h: Likewise.
Mention every single define your remove.
* sysdeps/x86_64/multiarch/bzero.S: Remove.
* sysdeps/x86_64/multiarch/memset-x86-64.S: Likewise.
* sysdeps/x86_64/multiarch/memset.S: Likewise.
* sysdeps/x86_64/multiarch/memset_chk.S: Likewise.
The patch itself is fine, please send an updated changelog for review,
thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126