This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove Prefer_SSE_for_memop on x64
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 7 Mar 2013 17:20:53 +0100
- Subject: Re: [PATCH] Remove Prefer_SSE_for_memop on x64
- References: <20130214213001.GA11656@domone.kolej.mff.cuni.cz><513859FB.8040208@suse.com>
On Thu, Mar 07, 2013 at 10:12:27AM +0100, Andreas Jaeger wrote:
> On 02/14/2013 10:30 PM, OndÅej BÃlka wrote:
> >Hello,
> >As I asked in
> >http://www.sourceware.org/ml/libc-alpha/2013-02/msg00203.html
> >nobody objected to keep non-sse memset on x64.
> >
> >This patch removes that implementation and flag Prefer_SSE_for_memop
> >which is always set and only choose sse memset over nonsse one.
> >
> >2013-02-14 OndÅej BÃlka <neleai@seznam.cz>
> >
> > * sysdeps/x86_64/memset.S: Always define bcopy.
>
> I suggest:
> Remove USE_MULTIARCH conditional for definining bcopy.
I will remove that.
>
> > * sysdeps/x86_64/multiarch/Makefile: Update.
>
> Which variable are you changing - and how?
>
> > * sysdeps/x86_64/multiarch/ifunc-impl-list.c: Update.
> > * sysdeps/x86_64/multiarch/init-arch.c: Remove Prefer_SSE_for_memop.
>
> The two entries above miss the function changed. Replace Update with
> a proper description.
>
> > * sysdeps/x86_64/multiarch/init-arch.h: Likewise.
>
> Mention every single define your remove.
>
> > * sysdeps/x86_64/multiarch/bzero.S: Remove.
> > * sysdeps/x86_64/multiarch/memset-x86-64.S: Likewise.
> > * sysdeps/x86_64/multiarch/memset.S: Likewise.
> > * sysdeps/x86_64/multiarch/memset_chk.S: Likewise.
> >
>
> The patch itself is fine, please send an updated changelog for review,
>
> thanks,
> Andreas
Here is updated changelog
* sysdeps/x86_64/memset.S: Always define bcopy.
* sysdeps/x86_64/multiarch/init-arch.c: Remove
Prefer_SSE_for_memop.
* sysdeps/x86_64/multiarch/init-arch.h: Remove
bit_Prefer_SSE_for_memop, index_Prefer_SSE_for_memop,
HAS_PREFER_SSE_FOR_MEMOP.
* sysdeps/x86_64/multiarch/bzero.S: Remove.
* sysdeps/x86_64/multiarch/memset-x86-64.S: Likewise.
* sysdeps/x86_64/multiarch/memset.S: Likewise.
* sysdeps/x86_64/multiarch/memset_chk.S: Likewise.
* sysdeps/x86_64/multiarch/Makefile: Do not compile memset-x86-64.
* sysdeps/x86_64/multiarch/ifunc-impl-list.c (bzero, memset):
Remove ifunc