This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fi_FI: Define yesstr, nostr
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: myllynen at redhat dot com, Keld Simonsen <keld at keldix dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 15 Mar 2013 11:50:14 -0400
- Subject: Re: [PATCH] fi_FI: Define yesstr, nostr
- References: <5141EF6D.9000601@redhat.com> <514334DF.8000306@redhat.com>
On 03/15/2013 10:49 AM, Carlos O'Donell wrote:
> On 03/14/2013 11:40 AM, Marko Myllynen wrote:
>> Hi,
>>
>> attached is a patch to define yesstr/nostr in fi_FI (as "KyllÃ" and
>> "Ei", obviously). I happened to notice BZ #15264 so this is related
>> but definitely does not warrant closing it so I chose to omit the
>> reference from the ChangeLog entry.
>>
>> localedata/
>>
>> 2013-03-14 Marko Myllynen <myllynen@redhat.com>
>>
>> * locales/fi_FI (LC_MESSAGES): Define yesstr, nostr.
>
> This looks good to me, could you do me a favour?
>
> (a) Include in a comment the unicode values of yesstr/nostr, this makes
> review easier for future readers.
>
> e.g.
>
> % yesstr/nostr KyllÃ/Ei
>
> (b) Can you build the library to make sure the locale is compiled correctly
> and without error?
>
> I've included Keld in the TO since as the author of the locale it would
> be nice if he could comment on the change.
>
> After review, and once we checkin your changes you should update the BZ
> to indicate you've fixed fi_FI.
And again with Keld's new address.
Cheers,
Carlos.