This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Promote a math test for sNaN handling to the top-level.
On Mon, 18 Mar 2013, Thomas Schwinge wrote:
> diff --git math/math-tests.h math/math-tests.h
I think sysdeps/generic would be a better place for this header, as I can
see uses for such a header in tests outside the math/ directory
(specifically, to give strtod tests information about rounding mode
support for different types).
> +#ifndef SNAN_TESTS_float
> +# define SNAN_TESTS_float 1
> +#endif
I think the default definition of each macro should have a comment
explaining its semantics.
> +/* On 32-bit x86, current versions of GCC are happy to use FPU load
And where you say "current", name the versions for which this is known to
be the case (up to at least 4.8?).
--
Joseph S. Myers
joseph@codesourcery.com