This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Allow adding arbitrary code to benchmark tests


Siddhesh Poyarekar <siddhesh@redhat.com> writes:

>  $(objpfx)bench-%.c: %-inputs bench-skeleton.c
> +	{ if [ -n "$($*-INCLUDE)" ]; then \
> +	  cat $($*-INCLUDE); \
> +	fi; \
>  	$(..)scripts/bench.pl $(patsubst %-inputs,%,$<) \
> -	  $($*-ITER) $($*-ARGLIST) $($*-RET) > $@
> +	  $($*-ITER) $($*-ARGLIST) $($*-RET); } > $@

One more thing: please output to a temporary file and move it to the
target afterwards.  Otherwise looks good.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]