This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v2] Rebuild benchmark sources when Makefile is updated
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 9 Apr 2013 10:18:56 +0530
- Subject: [PATCH v2] Rebuild benchmark sources when Makefile is updated
- References: <20130403080526 dot GA20842 at spoyarek dot pnq dot redhat dot com> <20130408220956 dot 124492C09F at topped-with-meat dot com>
On Mon, Apr 08, 2013 at 03:09:56PM -0700, Roland McGrath wrote:
> I may be missing some context because I didn't find time to review your
> original bench/ additions and they went in without my involvement.
>
> Why is any of this stuff in Rules at all? It appears to be relevant only
> to bench/Makefile and so it should be there. Is there some intent to
> support the 'bench' variable in other subdir makefiles?
and here's this patch updated to apply to benchtests/Rules instead.
Siddhesh
* benchtests/Rules ($(objpfx)bench-%.c): Depend on Makefile.
diff --git a/benchtests/Rules b/benchtests/Rules
index 4715084..9906bb0 100644
--- a/benchtests/Rules
+++ b/benchtests/Rules
@@ -40,7 +40,7 @@ $(binaries-bench): %: %.o \
$(addprefix $(csu-objpfx),start.o) $(+preinit) $(+postinit)
$(+link)
-$(objpfx)bench-%.c: %-inputs bench-skeleton.c
+$(objpfx)bench-%.c: %-inputs bench-skeleton.c Makefile
{ if [ -n "$($*-INCLUDE)" ]; then \
cat $($*-INCLUDE); \
fi; \