This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch v2] Dryrun framework.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 16 Apr 2013 11:49:41 +0200
- Subject: Re: [Patch v2] Dryrun framework.
- References: <20130409192249 dot GA11662 at domone dot kolej dot mff dot cuni dot cz> <5165B9B5 dot 5030604 at redhat dot com> <20130414150647 dot GA5557 at domone>
ping
On Sun, Apr 14, 2013 at 05:06:50PM +0200, OndÅej BÃlka wrote:
> On Wed, Apr 10, 2013 at 03:12:53PM -0400, Carlos O'Donell wrote:
> > On 04/09/2013 03:22 PM, OndÅej BÃlka wrote:
> > > OK to commit?
> >
> > Not yet. Look at my comments and post v2.
> >
> Here is v2
> > > Ondra
> > >
> * dryrun/common/common.h: New file.
> * dryrun/common/record_common.h: New file.
> * dryrun/common/replay_common.h: New file.
> * dryrun/exp/Makefile: New file.
> * dryrun/exp/analyze.i: New file.
> * dryrun/exp/layout.h: New file.
> * dryrun/exp/record.c: New file.
> * dryrun/exp/replay.c: New file.
> * dryrun/exp/show.c: New file.
> * dryrun/sysdeps/generic.h: New file.
> * dryrun/sysdeps/x86_64.h: New file.
>
> > +
> > > +/* TODO Placeholder function. */
> > > +/* We can use backtrace as it depends on libgcc which causes dlopen->backtrace->dlopen infinite loop. */
> >
> > Line too long.
> >
> > If we don't have backtrace support remove it from the code.
> >
> I have it in x86, I added dryrun/sysdeps/x86_64.h file that I planed add
> later.
> > > +static uint64_t __attribute__ ((noinline)) backtrace2 ()
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > +/* TODO now only linux specific. */
> >
> > We shouldn't have any todo's, Just comment that it's linux specific.
> >
> Its work in progress, best to see what I will do.
>
> I also added placeholder to python bindings. I plan to generate them with swig.
>