This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add benchmark inputs for cos and tan
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Wed, 17 Apr 2013 13:18:29 +0200
- Subject: Re: [PATCH] Add benchmark inputs for cos and tan
- References: <20130417094703 dot GJ3367 at spoyarek dot pnq dot redhat dot com>
On Wednesday, April 17, 2013 15:17:03 Siddhesh Poyarekar wrote:
> Hi,
>
> Attached patch adds inputs for cos and tan for the slow and fast
> paths. OK to commit?
>
> Siddhesh
>
> * benchtests/Makefile (bench): Add cos, tan, slowcos and
> slowtan.
> * benchtests/cos-inputs: New file.
> * benchtests/slowcos-inputs: New file.
> * benchtests/slowcos.c: New file.
> * benchtests/slowtan-inputs: New file.
> * benchtests/slowtan.c: New file.
> * benchtests/tan-inputs: New file.
>
> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index 5d3de5d..c61fd87 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -45,7 +45,8 @@
> # See pow-inputs for an example.
>
> subdir := benchtests
> -bench := exp pow rint sin atan slowexp slowpow slowsin slowatan
> +bench := exp pow rint sin cos tan atan \
> + slowexp slowpow slowsin slowcos slowtan slowatan
>
> # exp function fast path
> exp-ITER = 5e8
> @@ -77,6 +78,18 @@ sin-ARGLIST = double
> sin-RET = double
> LDFLAGS-bench-sin = -lm
>
> +# cos function fast path
since we might have different implementations, shouldn't we add the file
name you're talking about?
Otherwise the change is fine,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126