This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR ld/15365: Restrict __ehdr_start's export class (was: RE: [COMMITTED PATCH] Use __ehdr_start, if available, as fallback for AT_PHDR.)


I think STV_HIDDEN is fine for __ehdr_start.  I made it STV_DEFAULT because
that's what's done for similar magic symbols such as __start_section_name.
IMHO the linker(s) should be consistent and produce STV_HIDDEN for those
too, but that's not my call (and I didn't care to pursue that unrelated
issue when I was implementing __ehdr_start).

The libc change is fine regardless of the resolution of binutils issues.
(It's not a material optimization for any target I understand, since it's
only in code that's compiled non-PIC anyway.  But I concur about its
correctness as a documentation of intent.)  Go ahead and commit that.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]