This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: modf optimization
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 26 Apr 2013 15:31:23 -0300
- Subject: Re: [PATCH] PowerPC: modf optimization
- References: <51508CA8 dot 5090203 at linux dot vnet dot ibm dot com> <515091DD dot 5030504 at suse dot com> <51509695 dot 7020508 at linux dot vnet dot ibm dot com> <CAAHN_R3H+6gxbCRWqGapdz5JGJhfVLePqfo08P4xGkaDMXRRUg at mail dot gmail dot com> <5152F9C4 dot 1000705 at linux dot vnet dot ibm dot com> <5152FE2E dot 9060309 at suse dot com> <5158B110 dot 2070206 at linux dot vnet dot ibm dot com> <51630C7C dot 2040506 at linux dot vnet dot ibm dot com> <516D56D7 dot 7050902 at linux dot vnet dot ibm dot com> <CAAKybw88meoSYL_h4SrRR_64C73OEyqATa+o+0mTz=3s9SfVeg at mail dot gmail dot com> <CAAHN_R2mtiPDHbUHTC+3rzjagHWXnTRnA7qg3yu9ai78ymVC+w at mail dot gmail dot com> <5176D617 dot 9080206 at linux dot vnet dot ibm dot com>
On 04/23/2013 03:42 PM, Adhemerval Zanella wrote:
> On 23-04-2013 00:22, Siddhesh Poyarekar wrote:
>> On 23 April 2013 02:25, Ryan S. Arnold <ryan.arnold@gmail.com> wrote:
>>> I'm fine with the mod_f changes. I couldn't tell from this discussion
>>> whether the benchmark changes were redundant or not. I trust you'll
>>> test this against trunk before it's checked in.
>> The benchmark changes are fine once bench-modf.c has been formatted
>> correctly according to GNU standards.
>>
>> Siddhesh
>> --
>> http://siddhesh.in
>>
> I formatted bench-modf.c and push upstream as 3c0265394d9ffedff2b0de508602dc52e077ce5c.
> Thanks for the review and comments.
>
HI all,
I pushed a fix aa630f590c9c7d070a7cdf3a2a88069ad6b63de9 to correct the default PPC arch
to enable this optimization, changing it from power5 to power5+ as intended in patch
(since only on power5+ ISA 2.03 round() and ceil() will be inline to FP intrinsics
instructions instead of function cals).