This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX


In __lll_lock_elision() there is this comment:

> +             /* Lock was busy. Fall back to normal locking.
> +                Could also _xend here but xabort with 0xff code
> +                is more visible in the profiler. */
> +             _xabort (_ABORT_LOCK_BUSY);

The code is certainly correct here, but I guess the comment is
not.  I think you could _not_ use _xend() here because the
transactions might be nested, and _xend() would end only the
innermost transaction level and not abort the outermost
transaction.  At least if I understand Intel transactions
correctly.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt
IBM Germany


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]