This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- From: Dominik Vogt <vogt at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 6 May 2013 14:44:14 +0200
- Subject: Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- References: <1367537252-30831-1-git-send-email-andi at firstfloor dot org> <1367537252-30831-3-git-send-email-andi at firstfloor dot org>
- Reply-to: vogt at linux dot vnet dot ibm dot com
In __lll_lock_elision() there is this comment:
> + /* Lock was busy. Fall back to normal locking.
> + Could also _xend here but xabort with 0xff code
> + is more visible in the profiler. */
> + _xabort (_ABORT_LOCK_BUSY);
The code is certainly correct here, but I guess the comment is
not. I think you could _not_ use _xend() here because the
transactions might be nested, and _xend() would end only the
innermost transaction level and not abort the outermost
transaction. At least if I understand Intel transactions
correctly.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany