This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: fix hypot/hypof FP exceptions
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 6 May 2013 12:32:51 -0500
- Subject: Re: [PATCH] PowerPC: fix hypot/hypof FP exceptions
- References: <517EADAF dot 8000601 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1304292033400 dot 15327 at digraph dot polyomino dot org dot uk> <517FDCCE dot 3040808 at linux dot vnet dot ibm dot com> <5183A15E dot 1040809 at linux dot vnet dot ibm dot com> <5187E629 dot 3090204 at linux dot vnet dot ibm dot com>
On Mon, May 6, 2013 at 12:19 PM, Adhemerval Zanella
<azanella@linux.vnet.ibm.com> wrote:
> Ping.
>
> On 05/03/2013 08:37 AM, Adhemerval Zanella wrote:
>> On 04/30/2013 12:01 PM, Adhemerval Zanella wrote:
>>> On 29-04-2013 17:35, Joseph S. Myers wrote:
>>>> On Mon, 29 Apr 2013, Adhemerval Zanella wrote:
>>>>
>>>>> This patch fixes spurious overflow FP generated in PowerPC hypot code triggered
>>>>> by recent cacos/cacosh/casin/casinh tests with argument as [+/-]0x1.fp-129 for
>>>>> float and [+/-] 0x1.fp-1025 for double.
>>>>>
>>>>> For hypotf I removed the unneeded tests (since sqrt for double precision will be
>>>>> used in the end).
>>>>>
>>>>> For hypot I adjusted the test to check if x/y with x>y is higher than 2^60 by
>>>>> checking if first y * 2^60 will overflow. If so, the test used is x > (y*2^60).
>>>>>
>>>>> With this patch and the previous ULPs update , I'm not seeing any more issues
>>>>> on float and double testcases for PowerPC. Tested on PPC32 and PPC64.
>>>>>
>>>>> Any tips, comments, advices?
>>>> In a case such as this I advise:
>>>>
>>>> * File a bug in Bugzilla for the user-visible hypot issues, and reference
>>>> the bug number as [BZ #N] in the ChangeLog entry for the fix.
>>>>
>>>> * As part of the patch fixing the bug, add testcases that directly test
>>>> those hypot issues, rather than relying on the tests for another function
>>>> to cover this bug.
>>>>
>>> Thanks for reply Joseph. I have create the bugzillas and update the patch with specific
>>> tests.
>>>
>>> ---
>>>
>>>
>> I updated the patch with NEWS additions of fixed bugs. Ok to commit?
I'm fine with this.
Ryan