This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #12685] Allow arbitrary number of modes in fopen.


On 05/09/2013 11:34 AM, Joseph S. Myers wrote:
> On Thu, 9 May 2013, Ondrej Bilka wrote:
> 
>> Hi,
>>
>> I implemented  Michael Kerrisk's suggestion from
>> http://sourceware.org/bugzilla/show_bug.cgi?id=12685
>> to read mode until NULL or comma (for ,ccs=) is reached.
>>
>> OK to commit?
>>
>> Ondra
>>
>> 	* libio/fileops.c (_IO_new_file_fopen): Allow arbitrary number of modes.
>> 	* libio/iofdopen.c (_IO_new_fdopen): Likewise.
> 
> I think this should add testcases (for both functions) that a mode late in 
> a long string is properly handled.
> 

I agree we need test cases for this to prevent regression.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]