This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ #12685] Allow arbitrary number of modes in fopen.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 14:42:57 +0200
- Subject: Re: [PATCH v2][BZ #12685] Allow arbitrary number of modes in fopen.
- References: <20130509152046 dot GA4242 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1305091533180 dot 25142 at digraph dot polyomino dot org dot uk> <518BEFB2 dot 80304 at redhat dot com> <20130510103330 dot GA12338 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1305101139470 dot 1189 at digraph dot polyomino dot org dot uk> <20130514121540 dot GA28892 at domone dot kolej dot mff dot cuni dot cz> <mvm38tpzqst dot fsf at hawking dot suse dot de>
On Tue, May 14, 2013 at 02:31:14PM +0200, Andreas Schwab wrote:
> OndÅej BÃlka <neleai@seznam.cz> writes:
>
> > diff --git a/libio/fileops.c b/libio/fileops.c
> > index 61b61b3..50c3eb2 100644
> > --- a/libio/fileops.c
> > +++ b/libio/fileops.c
> > @@ -286,12 +286,10 @@ _IO_new_file_fopen (fp, filename, mode, is32not64)
> > #ifdef _LIBC
> > last_recognized = mode;
> > #endif
> > - for (i = 1; i < 7; ++i)
> > + while (*mode && *mode != ',')
> > {
> > switch (*++mode)
>
> That reads mode[1], but the loop conditions tests mode[0].
>
This is still valid, to preserve original control flow.