This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH rsa/power8] PowerPC: Add support for POWER8.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: rsa at us dot ibm dot com
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 16 May 2013 16:58:01 -0700 (PDT)
- Subject: Re: [PATCH rsa/power8] PowerPC: Add support for POWER8.
- References: <1368725852 dot 6842 dot 11 dot camel at localhost dot localdomain>
> -/* There are 25 bits used in AT_HWCAP, but they are bits 7..31. */
> +/* There are 25 bits used in AT_HWCAP, but they are bits 7..31. The feature
> + * definitions started at bit 31 and decremented as new features were added.
> + */
> +#define _DL_HWCAP_LAST 31
Comment style.
> +/* AT_HWCAP2 feature bits similarily started at bit 31 and decremented as new
> + * features were added. */
> +#define _DL_HWCAP2_LAST 31
Here too.
Nothing else popped out at me and this is all in powerpc directories, so
it's your call to declare it tested enough.
Thanks,
Roland