This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH rsa/power8] PowerPC: Add support for POWER8.


> -/* There are 25 bits used in AT_HWCAP, but they are bits 7..31.  */
> +/* There are 25 bits used in AT_HWCAP, but they are bits 7..31.  The feature
> + * definitions started at bit 31 and decremented as new features were added.
> + */
> +#define _DL_HWCAP_LAST		31

Comment style.

> +/* AT_HWCAP2 feature bits similarily started at bit 31 and decremented as new
> + * features were added.  */
> +#define _DL_HWCAP2_LAST		31

Here too.

Nothing else popped out at me and this is all in powerpc directories, so
it's your call to declare it tested enough.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]