This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ #13152] fmemopen does not honor append mode.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Mon, 20 May 2013 10:43:29 +0200
- Subject: Re: [PATCH v2][BZ #13152] fmemopen does not honor append mode.
- References: <20130509164726 dot GA32347 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1305091653510 dot 25142 at digraph dot polyomino dot org dot uk> <20130514131101 dot GA3860 at domone dot kolej dot mff dot cuni dot cz> <20130517002937 dot 430692C084 at topped-with-meat dot com>
On Thu, May 16, 2013 at 05:29:37PM -0700, Roland McGrath wrote:
> > - tst-mmap2-eofsync tst-mmap-offend test-fopen-bz12685 bug-fopena+ bug-wfflush \
> > + tst-mmap2-eofsync tst-mmap-offend test-fopen-bz12685 test-fmemopen-bz13152 bug-fopena+ bug-wfflush \
>
> This line is too long (it already was, but fix it now).
>
> > + if (mode[0] == 'a')
> > + {
> > + len -= c->maxpos;
> > + c->buffer += c->maxpos;
> > + c->maxpos = 0;
> > + }
>
> How can this possibly be right for "a+" mode or ftell?
>
ok, need will post new version.