This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Don't include expected results in libm-test test names


This patch stops libm test names, as used in libm-test-ulps files,
from including the expected result of the test.  This is with a view
to most expected results being generated automatically by MPFR/MPC in
future separately for each floating-point format: then the text of the
expected result for a given input will differ slightly between
floating-point formats, but if the input is exactly the same it's
still good for them to be considered the same test for libm-test-ulps
files.

Tested x86_64 and x86.  I updated all the libm-test-ulps files using
sed (and running gen-libm-test.pl -n on them in case any consequent
reordering was needed); full diff attached gzipped, since it's nearly
4MB uncompressed.  Note that for the actual move to MPFR-based
generation of expected values (probably not for 2.18), it will be
necessary to regenerate all the libm-test-ulps files from scratch, as
all test inputs for MPFR-based tests will I expect end up in hex float
format.

This patch approximately halves the sizes of the libm-test-ulps files
(in bytes, of course the size in lines doesn't change significantly).

2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* math/gen-libm-test.pl (parse_args): Do not include expected
	result in test name.
	* sysdeps/i386/fpu/libm-test-ulps: Update test names.
	* sysdeps/powerpc/fpu/libm-test-ulps: Likewise.
	* sysdeps/s390/fpu/libm-test-ulps: Likewise.
	* sysdeps/sh/sh4/fpu/libm-test-ulps: Likewise.
	* sysdeps/sparc/fpu/libm-test-ulps: Likewise.
	* sysdeps/x86_64/fpu/libm-test-ulps: Likewise.

ports/ChangeLog.aarch64
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/aarch64/libm-test-ulps: Update test names.

ports/ChangeLog.alpha
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/alpha/fpu/libm-test-ulps: Update test names.

ports/ChangeLog.arm
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/arm/libm-test-ulps: Update test names.

ports/ChangeLog.hppa
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/hppa/fpu/libm-test-ulps: Update test names.

ports/ChangeLog.ia64
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/ia64/fpu/libm-test-ulps: Update test names.

ports/ChangeLog.m68k
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/m68k/coldfire/fpu/libm-test-ulps: Update test names.
	* sysdeps/m68k/m680x0/fpu/libm-test-ulps: Likewise.

ports/ChangeLog.microblaze
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/microblaze/libm-test-ulps: Update test names.

ports/ChangeLog.mips
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/mips/mips32/libm-test-ulps: Update test names.
	* sysdeps/mips/mips64/libm-test-ulps: Likewise.

ports/ChangeLog.powerpc
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/powerpc/nofpu/libm-test-ulps: Update test names.

ports/ChangeLog.tile
2013-05-21  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/tile/libm-test-ulps: Update test names.

diff --git a/math/gen-libm-test.pl b/math/gen-libm-test.pl
index c50e27d..e1a32e5 100755
--- a/math/gen-libm-test.pl
+++ b/math/gen-libm-test.pl
@@ -198,20 +198,17 @@ sub parse_args {
     die ("$descr[$i] is unknown");
   }
   $call .= ')';
-  $str = "$call == ";
+  $str = $call;
 
   # Result
   @descr = split //,$descr_res;
   foreach (@descr) {
     if ($_ =~ /f|i|l|L/) {
-      $str .= &beautify ($args[$current_arg]);
       ++$current_arg;
     } elsif ($_ eq 'c') {
-      $str .= &build_complex_beautify ($args[$current_arg], $args[$current_arg+1]);
       $current_arg += 2;
     } elsif ($_ eq 'b') {
       # boolean
-      $str .= ($args[$current_arg] == 0) ? "false" : "true";
       ++$current_arg;
     } elsif ($_ eq '1') {
       ++$current_arg;

-- 
Joseph S. Myers
joseph@codesourcery.com

Attachment: glibc-libm-test-name.gz
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]