This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Tue, 28 May 2013 20:02:15 -0400
- Subject: Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1369507293-19498-1-git-send-email-vapier at gentoo dot org> <51A50663 dot 20306 at redhat dot com> <201305281805 dot 15814 dot vapier at gentoo dot org> <20130528231539 dot 7C5CB2C05D at topped-with-meat dot com>
On 05/28/2013 07:15 PM, Roland McGrath wrote:
>> On Tuesday 28 May 2013 15:32:51 Carlos O'Donell wrote:
>>> On 05/25/2013 02:41 PM, Mike Frysinger wrote:
>>>> +#define PTR_ALIGN_UP(base, size) \
>>>> + (void *) ALIGN_UP ((uintptr_t) (base), (size))
>>>
>>> Almost done.
>>>
>>> We install cdefs.h and thus these macros need __ to avoid being
>>> in the user's namespace.
>>
>> not exactly. i picked include/sys/cdefs.h instead of misc/sys/cdefs.h because
>> the latter is for installing while the former is for internal use.
>
> I don't think you should use include/sys/cdefs.h for that sort of purpose.
> If it's internal-only stuff that doesn't directly relate to something else
> that's in the API of an installed header, then do it purely in a private
> header.
Do you care if we use include/libc-internal.h for this purpose?
c.