This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Tue, 28 May 2013 17:05:53 -0700 (PDT)
- Subject: Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1369327649-906-1-git-send-email-vapier at gentoo dot org> <1369507293-19498-1-git-send-email-vapier at gentoo dot org> <51A50663 dot 20306 at redhat dot com> <201305281805 dot 15814 dot vapier at gentoo dot org> <20130528231539 dot 7C5CB2C05D at topped-with-meat dot com> <51A54587 dot 2060106 at redhat dot com>
> > I don't think you should use include/sys/cdefs.h for that sort of purpose.
> > If it's internal-only stuff that doesn't directly relate to something else
> > that's in the API of an installed header, then do it purely in a private
> > header.
>
> Do you care if we use include/libc-internal.h for this purpose?
That's fine enough if there isn't a more specific natural-seeming name for
this. In this case we have a handful of macros (perhaps they really should
be inlines) that all go together, so adding an internal header just for
them (addr-align.h or something) makes sense too.