This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/6] Add fmemopen compatibility version.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ondrej Bilka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 3 Jun 2013 15:54:52 +0000
- Subject: Re: [PATCH 2/6] Add fmemopen compatibility version.
- References: <1370099488-13916-1-git-send-email-neleai at seznam dot cz> <1370099488-13916-3-git-send-email-neleai at seznam dot cz>
On Sat, 1 Jun 2013, Ondrej Bilka wrote:
> + GLIBC_2.17 {
> + fmemopen;
> + }
That's certainly wrong. The next glibc release is 2.18, so the new
version of fmemopen would use GLIBC_2.18 (or 2.19 if it doesn't get into
2.18).
> +#if SHLIB_COMPAT (libc, GLIBC_2_17, GLIBC_2_18)
I believe this should be
#if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_18)
since the symbol was introduced in version 2.2 and this version was
obsoleted in 2.18.
You may also need a versioned_symbol call to give the new fmemopen the
right version; I'm not sure if that's required or if listing the new
version in the Versions file will be sufficient.
> +compat_symbol (libc, oldfmemopen, fmemopen, GLIBC_2_17);
And that should use GLIBC_2_2.
--
Joseph S. Myers
joseph@codesourcery.com