This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Change __ASSUME_ACCEPT4 on powerpc to 2.6.37


On Tue, Jun 04, 2013 at 07:58:07PM +0000, Joseph S. Myers wrote:
> 
> This bug should be filed in Bugzilla as it looks like something that
> would have been a user-visible bug in a release.  (Whereas cases where
> an __ASSUME_* macro isn't defined but could be are simply missing 
> optimizations, so don't need bugs filed when fixing them.)

I probably should file it, yes.  Especially in light of the fact that,
as pointed out, my patch might not actually address the issue, because
the logic in accept4.c doesn't actually get me where I want to go if I
build against newer headers.

As for the hunting of ASSUME vs. syscall lists versus releases versus
architectures, I agree that this would be both a very useful project,
and a bit of a pain in the butt to do.  I did, at least, quickly skim
for any other issues that vaguely related to this commit and PowerPC,
and the accept4 thing seemed to be its own brand of special.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]