This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Change __ASSUME_ACCEPT4 on powerpc to 2.6.37
- From: Adam Conrad <adconrad at 0c3 dot net>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 4 Jun 2013 23:03:14 -0600
- Subject: Re: [PATCH] Change __ASSUME_ACCEPT4 on powerpc to 2.6.37
- References: <20130604124225 dot GQ4389 at 0c3 dot net> <Pine dot LNX dot 4 dot 64 dot 1306041949370 dot 10197 at digraph dot polyomino dot org dot uk>
On Tue, Jun 04, 2013 at 07:58:07PM +0000, Joseph S. Myers wrote:
>
> This bug should be filed in Bugzilla as it looks like something that
> would have been a user-visible bug in a release. (Whereas cases where
> an __ASSUME_* macro isn't defined but could be are simply missing
> optimizations, so don't need bugs filed when fixing them.)
I probably should file it, yes. Especially in light of the fact that,
as pointed out, my patch might not actually address the issue, because
the logic in accept4.c doesn't actually get me where I want to go if I
build against newer headers.
As for the hunting of ASSUME vs. syscall lists versus releases versus
architectures, I agree that this would be both a very useful project,
and a bit of a pain in the butt to do. I did, at least, quickly skim
for any other issues that vaguely related to this commit and PowerPC,
and the accept4 thing seemed to be its own brand of special.