This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix unary operator spacing.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 10 Jun 2013 13:56:32 +0000
- Subject: Re: [PATCH] Fix unary operator spacing.
- References: <20130610115907 dot GA9457 at domone> <Pine dot LNX dot 4 dot 64 dot 1306101230520 dot 5269 at digraph dot polyomino dot org dot uk> <20130610133110 dot GA27104 at domone>
On Mon, 10 Jun 2013, Ondrej Bilka wrote:
> On Mon, Jun 10, 2013 at 12:32:26PM +0000, Joseph S. Myers wrote:
> > On Mon, 10 Jun 2013, Ondrej Bilka wrote:
> >
> > > Continuing code cleanup now we focus on !~ followed by space.
> > > Patch is at
> > > http://www.kam.mff.cuni.cz/~ondra/fix_unary_operator_spacing.patch
> >
> > Does not appear to exist.
> There was extra www there.
>
> http://kam.mff.cuni.cz/~ondra/fix_unary_operator_spacing.patch
A quick look over parts of the patch shows cases where this moves the open
parenthesis of a function or macro call, that continues to a subsequent
line, to the left, so requiring reindentation of subsequent lines of that
call. In such cases, please either include the required reindentation in
the patch (possibly done by a manual editing stage after the initial
automatic changes), or else exclude such cases and just fix easy cases in
the automatically generated patch, leaving the hard cases for later (I
suggest the latter, since it makes the patch smaller and easier to
review).
--
Joseph S. Myers
joseph@codesourcery.com