This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix readdir_r with long file names
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Rich Felker <dalias at aerifal dot cx>, KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 10 Jun 2013 19:17:59 -0400
- Subject: Re: [PATCH] Fix readdir_r with long file names
- References: <20130516125029 dot GE11420 at spoyarek dot pnq dot redhat dot com> <5194D697 dot 8040106 at redhat dot com> <20130516130952 dot GA16952 at spoyarek dot pnq dot redhat dot com> <519B58EC dot 6060108 at redhat dot com> <51B0A2F9 dot 5060004 at redhat dot com> <51B0B39F dot 4060202 at redhat dot com> <51B0BD36 dot 3030202 at redhat dot com> <CAHGf_=r9Rz63pho+84ORk0a_oDyJSj-MCnZ56uPrT3L6sVEfeQ at mail dot gmail dot com> <20130607013024 dot GO29800 at brightrain dot aerifal dot cx> <51B19203 dot 3070307 at redhat dot com> <20130607144143 dot GQ29800 at brightrain dot aerifal dot cx> <51B57E35 dot 4080403 at redhat dot com>
On 06/10/2013 03:20 AM, Florian Weimer wrote:
> On 06/07/2013 04:41 PM, Rich Felker wrote:
>> Yes. I just disagree with recommending that portable applications
>> use readdir_r (as discussed on the Austin Group tracker/list, it
>> has major problems related to NAME_MAX not being mandatory) and
>> with the idea (by someone else, not you) to add a readdir4 rather
>> than just deprecating caller-provided buffers for reading
>> directories. Those were the only things I was commenting on.
>
> Carlos, what do you think about this? I tend to agree with Rich here
> and would like to back out this part of your suggestions again.
I'm OK with backing out the recommendation of readdir_r as a portable
alternative, but the text should instead say *why* readdir_r is not
a good portable alternative. That is to say we should specifically
dissuade the use if that's actually the truth.
Cheers,
Carlos.