This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix readdir_r with long file names

From: Florian Weimer <fweimer at redhat dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>, "Carlos O'Donell" <carlos at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
Date: Tue, 11 Jun 2013 09:50:57 +0200
Subject: Re: [PATCH] Fix readdir_r with long file names
References: <519220C7 dot 6050705 at redhat dot com> <20130516110136 dot GB11420 at spoyarek dot pnq dot redhat dot com> <5194CDEE dot 4020708 at redhat dot com> <20130516125029 dot GE11420 at spoyarek dot pnq dot redhat dot com> <5194D697 dot 8040106 at redhat dot com> <20130516130952 dot GA16952 at spoyarek dot pnq dot redhat dot com> <519B58EC dot 6060108 at redhat dot com> <51B0A2F9 dot 5060004 at redhat dot com> <51B0B39F dot 4060202 at redhat dot com> <51B0BD36 dot 3030202 at redhat dot com> <CAHGf_=r9Rz63pho+84ORk0a_oDyJSj-MCnZ56uPrT3L6sVEfeQ at mail dot gmail dot com> <51B0F1DD dot 5070901 at redhat dot com> <20130610223627 dot 0F6CC2C09F at topped-with-meat dot com>

On 06/11/2013 12:36 AM, Roland McGrath wrote:

There's precedent for my approach in realpath, where we don't use
pathconf(path, _PC_PATH_MAX), either, but cap the path length at PATH_MAX.


That's just following vanilla POSIX.1 rules: if PATH_MAX is defined at
compile time, it's a fixed system-wide limit.  If PATH_MAX is not defined
at compile time, there might or might not be a limit and if there is a
limit it might be filesystem-specific; pathconf reports that.

We must continue to define PATH_MAX and NAME_MAX for backwardscompatibility reasons. This leads to ugly kludges when we're confrontedwith data from the kernel that exceeds the constants. (getwd is anothersuch place.)


--
Florian Weimer / Red Hat Product Security Team

Follow-Ups:
- Re: [PATCH] Fix readdir_r with long file names
  - From: Roland McGrath

References:
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer
- Re: [PATCH] Fix readdir_r with long file names
  - From: Carlos O'Donell
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer
- Re: [PATCH] Fix readdir_r with long file names
  - From: KOSAKI Motohiro
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer
- Re: [PATCH] Fix readdir_r with long file names
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]