This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Set/restore rounding mode only when needed
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, <libc-alpha at sourceware dot org>, Josef Reidinger <jreidinger at suse dot cz>
- Date: Tue, 11 Jun 2013 22:01:47 +0000
- Subject: Re: [PATCH] Set/restore rounding mode only when needed
- References: <20130605110719 dot GU13968 at spoyarek dot pnq dot redhat dot com> <51B6D0E0 dot 6070707 at suse dot com>
On Tue, 11 Jun 2013, Andreas Jaeger wrote:
> Siddhesh, this looks fine to me but I'd like to have Joseph look over it as
> well.
>
> Like him, I'm a bit concerned that we have so many macros now and would prefer
> to have this simpler but I couldn't come up directly with something better.
This patch is OK with me. I do wonder if it's possible to reduce the
number of macros and functions by always defining the rm_ctx type, as a
struct just containing fenv_t when the architecture doesn't have any
special tracking of updated_status, so that you don't need separate *_ctx
macros and functions and everything using libc_fe* and related functions
and macros just uses the rm_ctx type instead of using fenv_t directly.
As far as I can see, updated_status is only used in the
architecture-specific header for i386.
--
Joseph S. Myers
joseph@codesourcery.com