This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback

From: Ivo Raisr <ivosh at ivosh dot net>
To: libc-alpha at sourceware dot org
Cc: OndÅej BÃlka <neleai at seznam dot cz>
Date: Wed, 12 Jun 2013 04:36:52 -0700
Subject: Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
References: <CANXv6=sw64PRodqTgArqUHQLTcQd8eEE_==6QHVHgLn52jh=1Q at mail dot gmail dot com> <20130611081615 dot GA6224 at domone dot kolej dot mff dot cuni dot cz>

2013/6/11 OndÅej BÃlka <neleai@seznam.cz>:
>
> From functional part this patch is mostly OK.
>
> I realized that there is simpler way to do this. You could test in tdestroy
> if freefct is null and set it to freenop.

I am sorry but I don't get your point here?
Your description matches changes done by this patch so I am confused by
your statement...
Never mind.

>
> There are several style issues, see:
> http://sourceware.org/glibc/wiki/Style_and_Conventions
> and post v2.

I found just one style issue with opening parenthesis and its indentation.
If there are some more style issues, please list them explicitly.

New patch (v2) is attached.

Ivosh

Attachment: glibc-tdestroy-freefct-NULL-v2.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
  - From: OndÅej BÃlka
- Fwd: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
  - From: Ivo Raisr

References:
- Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
  - From: OndÅej BÃlka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]