This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Ivo Raisr <ivosh at ivosh dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 12 Jun 2013 13:47:00 +0200
- Subject: Re: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
- References: <CANXv6=sw64PRodqTgArqUHQLTcQd8eEE_==6QHVHgLn52jh=1Q at mail dot gmail dot com> <20130611081615 dot GA6224 at domone dot kolej dot mff dot cuni dot cz> <CANXv6=vaJwfOKGgNWU55j-xdB5zqhp5_-3tdjS287+UR1r-nDA at mail dot gmail dot com>
On Wed, Jun 12, 2013 at 04:36:52AM -0700, Ivo Raisr wrote:
> 2013/6/11 OndÅej BÃlka <neleai@seznam.cz>:
> >
> > From functional part this patch is mostly OK.
> >
> > I realized that there is simpler way to do this. You could test in tdestroy
> > if freefct is null and set it to freenop.
>
> I am sorry but I don't get your point here?
> Your description matches changes done by this patch so I am confused by
> your statement...
> Never mind.
>
I thougth of something like
if (freefct==NULL) freefct=freenop;
> >
> > There are several style issues, see:
> > http://sourceware.org/glibc/wiki/Style_and_Conventions
> > and post v2.
>
> I found just one style issue with opening parenthesis and its indentation.
> If there are some more style issues, please list them explicitly.
>
> New patch (v2) is attached.
>
> Ivosh