This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5][v2][BZ #15022] Avoid repeated calls to DL_STATIC_INIT
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, <libc-alpha at sourceware dot org>
- Date: Wed, 19 Jun 2013 16:34:44 -0700 (PDT)
- Subject: Re: [PATCH 1/5][v2][BZ #15022] Avoid repeated calls to DL_STATIC_INIT
- References: <alpine dot DEB dot 1 dot 10 dot 1301152056590 dot 4834 at tp dot orcam dot me dot uk> <20130116215545 dot 7A37A2C0B0 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1301240655220 dot 4834 at tp dot orcam dot me dot uk> <20130531200059 dot C94C02C077 at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1306140202520 dot 16287 at tp dot orcam dot me dot uk> <20130619233103 dot A913F2C0A6 at topped-with-meat dot com>
I forgot to answer about the BZ# annotation. I don't think we have a clear
rule that would say. Since it is a necessary part of the fix, it probably
makes sense to use the annotation. For example, someone attempting to
backport the fix to a release branch would reasonably expect to look at all
the changes mentioning that BZ# and think those are all the ones directly
required in the backport. By that logic, it seems better to err on the
side of superfluous annotations rather than missing ones.
Thanks,
Roland