This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v5] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: David Miller <davem at davemloft dot net>, vapier at gentoo dot org, libc-alpha at sourceware dot org
- Date: Wed, 19 Jun 2013 21:17:26 -0400
- Subject: Re: [PATCH 2/2 v5] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <20130619230242 dot 99D1D2C111 at topped-with-meat dot com> <20130619 dot 160945 dot 351998924661893149 dot davem at davemloft dot net> <20130619232341 dot A9C462C111 at topped-with-meat dot com> <20130619 dot 164631 dot 2015669758604184036 dot davem at davemloft dot net> <20130619235754 dot 18D332C111 at topped-with-meat dot com>
On 06/19/2013 07:57 PM, Roland McGrath wrote:
>> The point is I haven't seen anyone agree with you, and it's not
>> prudent to let a lone opinion (strictly in disagreement with all other
>> voiced opinions) hold this bug fix back.
>
> Everyone else who has commented at all has pretty much said that I'm right
> in the abstract but they just don't want to bother with being right when
> going with the flow seems adequate. That would be a more convincing
> attitude if what I've asked for were actually more than ten minutes more
> work.
I didn't say you were right.
I happen to believe that it's a bike-shed and the patch should
just go in already because it makes the code better.
In fact I think I've tried to get this patch in several times,
but to be fair you have contributed ideas that made it better,
and I appreciate that.
However, on this point you have three developers that disagree
with you.
Mike is fully within his right to check his patch in having gotten
consensus from a selection of developers. However, he knows that such
an action may upset you and that has consequences in a community.
What makes this patch easy is that it's neither an ABI nor API issue,
but just a bit of bike-shed about how generic or not generic the patch is.
I suggest Mike check the patch in.
>> Whilst we're not a fully democracy here, we shouldn't be a monarchy
>> either. This is especially true when everyone else is fine with the
>> way this change is implemented.
>
> We could call it a meritocracy, so my word goes not because I'm part of my
> illustrious dynasty, but because I happen to be right.
You can still be right, but if everyone disagrees with you, and
you're unwilling to work towards a consensus, then the patch is
going to get checked in without your consent.
Cheers,
Carlos.