This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATH] [BZ 15674] Fix reading past the array boundary in __memcmp_ssse3


On 06/25/2013 07:11 AM, Dmitrieva Liubov wrote:
> -       mov     -9(%rdi), %eax
> -       and     $0xff, %eax
> -       mov     -9(%rsi), %edx
> -       and     $0xff, %edx
> +/* Movzbl reads only one byte and
> + doesn't read past the array boundary.  */
> +
> +       movzbl  -9(%rdi), %eax
> +       movzbl  -9(%rsi), %edx

We surely don't need a comment about how a non-obscure x86 architecture insn
operates.  The fix itself itself is obviously correct.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]