This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Polished patch (crash after pthread_exit)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 26 Jun 2013 17:12:38 -0400
- Subject: Re: [PATCH] Polished patch (crash after pthread_exit)
- References: <CAKt5dD1-XUyCSdhys+J5NJbCYQTMunwpcmECvRm1F0VSR4Jh+w at mail dot gmail dot com> <51C89EEB dot 3030604 at suse dot com> <51C8B629 dot 5090206 at redhat dot com> <20130624214304 dot EC63D2C09B at topped-with-meat dot com> <51C9B434 dot 5000303 at redhat dot com> <20130626200615 dot CB3F12C081 at topped-with-meat dot com> <51CB4CFB dot 9080907 at redhat dot com> <20130626205616 dot 44F252C07E at topped-with-meat dot com>
On 06/26/2013 04:56 PM, Roland McGrath wrote:
>> I didn't either, I just discovered it, and it's probably hiding
>> a lot of problems. I think I'm going to revert this behaviour and
>> just start fixing the resulting bugs instead.
>
> Usually the rpm changelog will indicate when a change was made and (RH)
> bugzilla numbers it addressed, so you could find the original motivation.
> (Other times, Jakub just miraculously remembers all the details and will
> readily tell you more than you ever thought you wanted to know. ;-)
It was ~4.5 years ago that Fedora started doing this with
~~~
* Wed Feb 18 2009 Jakub Jelinek <jakub@redhat.com> 2.9.90-7
...
- ld -r the whole libpthread.a together to avoid endless issues with
-static ... -lpthread
...
~~~
In which we do:
~~~
...
$GCC -r -nostdlib -o libpthread.o -Wl,--whole-archive ./libpthread.a
rm libpthread.a
ar rcs libpthread.a libpthread.o
rm libpthread.o
...
~~~
I guess "endless issues" is as good a motivation as anything.
I see no BZ's associated with this change though.
I'll ask Jakub ;-)
Cheers,
Carlos.