This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Cleanup #if 0
- From: Ondrej Bilka <neleai at seznam dot cz>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Liubov Dmitrieva <liubov dot dmitrieva at gmail dot com>, Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 1 Jul 2013 22:31:46 +0200
- Subject: Cleanup #if 0
- References: <CAHjhQ93YUtMz14Aj7JfhJ7Tq++eC+23cA6yubh1KPRpKTvvkaw at mail dot gmail dot com> <51D0967A dot 7050102 at redhat dot com> <CAHjhQ92mTi8OmY7RBC3=sCaX=-xbgGH82pCBz4fCQkBLJcNqOA at mail dot gmail dot com> <CAMe9rOr8o7OnB0T0tG50J7oXmJJF_XOiUDLK6Gsc1tMu-NOFrQ at mail dot gmail dot com> <CAHjhQ90Hrj78WYJ_sQ2Eu7mzf63Wbnuihcv88KBMdxJo5q1Yxg at mail dot gmail dot com> <CAMe9rOojGtDZcb6Phk3a1sp+B3XhQwRJo9ZjovC==1OG2_8k=g at mail dot gmail dot com> <CAMe9rOro+9nJ2cXHfa4xa9TPZRfn_zt19waHc_80GLRWaC4K+g at mail dot gmail dot com>
On Mon, Jul 01, 2013 at 12:47:45PM -0700, H.J. Lu wrote:
> On Mon, Jul 1, 2013 at 12:31 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Mon, Jul 1, 2013 at 12:27 PM, Liubov Dmitrieva
> > <liubov.dmitrieva@gmail.com> wrote:
> >> It is disabled for both. Where do you see it doesn't?
> >>
> >
> > From:
> >
> > http://sourceware.org/git/?p=glibc.git;a=blob_plain;f=sysdeps/i386/i686/multiarch/strcasecmp.S;hb=HEAD
> >
> > I see __strcasecmp_sse4_2 is used when SHARED is define.
> >
>
> I see what is going on. This commit:
>
> http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=6abf346582ba678f4850a88b4a5950593841df1d
>
> missed the "#if 0" removal for libc.a in strncase.S and
> strcasecmp.S. "#if 0" should be removed when SHARED
> is defined.
>
As this caused problems it would be good idea to globaly remove code surrounded by
#if 0
It is easy to automate, question is how many parts can be used and what are bitrotten.
Perhaps I can touch only these that are older than a year.
Comments?