This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> Can you regenerate the patch? I did. I also removed memcmp and wmemcmp because we need better accuracy benchmarks to be sure about the boost there. For str**cmp it looks reasonable to install even measured the benchmarks we have in glibc. I attached my results again. 2013-07-03 Liubov Dmitrieva <liubov.dmitrieva@intel.com> * sysdeps/i386/i686/multiarch/strcmp.S: Skip SSE4_2 version if bit_Slow_SSE4_2 is set. * sysdeps/i386/i686/multiarch/strncase.S: Likewise. * sysdeps/i386/i686/multiarch/strcasecmp.S: Likewise. -- Liubov On Tue, Jul 2, 2013 at 7:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote: > On Mon, Jul 1, 2013 at 12:47 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >> On Mon, Jul 1, 2013 at 12:31 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >>> On Mon, Jul 1, 2013 at 12:27 PM, Liubov Dmitrieva >>> <liubov.dmitrieva@gmail.com> wrote: >>>> It is disabled for both. Where do you see it doesn't? >>>> >>> >>> From: >>> >>> http://sourceware.org/git/?p=glibc.git;a=blob_plain;f=sysdeps/i386/i686/multiarch/strcasecmp.S;hb=HEAD >>> >>> I see __strcasecmp_sse4_2 is used when SHARED is define. >>> >> >> I see what is going on. This commit: >> >> http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=6abf346582ba678f4850a88b4a5950593841df1d >> >> missed the "#if 0" removal for libc.a in strncase.S and >> strcasecmp.S. "#if 0" should be removed when SHARED >> is defined. >> > > Hi Liubov, > > I removed "#if 0" from strcasecmp.S and strncase.S. > Can you regenerate the patch? > > Thanks. > > -- > H.J.
Attachment:
benchmarks.txt
Description: Text document
Attachment:
silvermont2.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |