This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix multi-arch build with elision
- From: Markus Trippelsdorf <markus at trippelsdorf dot de>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Andi Kleen <andi at firstfloor dot org>, GNU C Library <libc-alpha at sourceware dot org>, Andi Kleen <ak at linux dot jf dot intel dot com>
- Date: Wed, 3 Jul 2013 17:45:40 +0200
- Subject: Re: [PATCH] Fix multi-arch build with elision
- References: <1372802224-11817-1-git-send-email-andi at firstfloor dot org> <20130703062139 dot GA516 at x4> <CAMe9rOrWVU4z_oNVZKdjV0GOW_grAqo=jvuMsCpHiPvoV-ADTg at mail dot gmail dot com> <20130703153055 dot GO6123 at two dot firstfloor dot org> <CAMe9rOpHZz5LU3oPtO-NSXjb0G+w=DMMBEX2Qs-RQ8+Q1jqSqA at mail dot gmail dot com>
On 2013.07.03 at 08:37 -0700, H.J. Lu wrote:
> On Wed, Jul 3, 2013 at 8:30 AM, Andi Kleen <andi@firstfloor.org> wrote:
> > On Wed, Jul 03, 2013 at 08:21:53AM -0700, H.J. Lu wrote:
> >> On Tue, Jul 2, 2013 at 11:21 PM, Markus Trippelsdorf
> >> <markus@trippelsdorf.de> wrote:
> >> > On 2013.07.02 at 14:57 -0700, Andi Kleen wrote:
> >> >> From: Andi Kleen <ak@linux.intel.com>
> >> >>
> >> >> This is the simplest fix I could come up with for Markus'
> >> >> no multiarch problem. Markus can you test please?
> >> >
> >> > Yes, it works fine. Thanks Andi.
> >> >
> >> > --
> >> > Markus
> >>
> >> Try this.
> >
> > I considered something similar first, but it would also need the same for
> > the glibc Versions file at least, to export __get_cpu_features
> > from the main glibc to pthread, right? Or would pthread use its own
> > version?
> >
>
> I think init-arch.o is duplicated in libc.so and libpthread.so.
Yes. Your patch works fine and is elegant. Thanks.
--
Markus