This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix missing declaration of LC_CTYPE nonascii-case element


On 07/22/2013 06:28 AM, Andreas Schwab wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
> 
>> While this looks correct to me I'm curious why we didn't detect
>> it when Ulrich fixed support for non-ascii locales in x86-64 in
>> 2011?
> 
> The strcasecmp tests were never run for non-C locales.

Perfect, that's exactly what I expected.

This patch looks good to me, but I'm nervous about adding tests
late in the 2.18 freeze.

What kind of coverage did you give this? x86/x86_64 and power?

> Andreas.
> 
> 	[BZ #15736]
> 	* locale/categories.def (LC_CTYPE): Add "nonascii-case" element.
> 	* string/Makefile (test-strcasecmp-ENV)
> 	(test-strcasecmp-ifunc-ENV): Define.
> 	* string/test-strcasecmp.c (test_main): Run tests in several
> 	locales.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]