This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Increase nptl test case buffer size so we really block on current Linux kernels.
- From: Andreas Jaeger <aj at suse dot com>
- To: David Miller <davem at davemloft dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 23 Jul 2013 06:54:22 +0200
- Subject: Re: [PATCH] Increase nptl test case buffer size so we really block on current Linux kernels.
- References: <20130722 dot 164636 dot 1013443019526329969 dot davem at davemloft dot net>
On 07/23/2013 01:46 AM, David Miller wrote:
>
> So the minimum SO_SNDBUF size has increased in recent Linux kernels,
> and the value is dependent upon the machine word size.
>
> Essentially the current value is something like:
>
> 2 * (2048 + roundup(sizeof(struct sk_buff), CACHE_LINE_SIZE))
>
> and the aim is to make sure that two fully sized packets can always
> be sent by TCP. This minimum is enforced for all protocols, not just
> TCP, because the enforcement occurs in the generic socket layer.
>
> Any objections? I get a clean sparc64 testsuite now with this change.
>
> * tst-cancel4.c (WRITE_BUFFER_SIZE): Increase to 16384.
>
> diff --git a/nptl/ChangeLog b/nptl/ChangeLog
> index fc2ef41..0e4747e 100644
> --- a/nptl/ChangeLog
> +++ b/nptl/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-07-22 David S. Miller <davem@davemloft.net>
> +
> + * tst-cancel4.c (WRITE_BUFFER_SIZE): Increase to 16384.
> +
> 2013-07-19 Dominik Vogt <vogt@de.ibm.com>
>
> * pthread_mutex_lock.c: Fix whitespace.
> diff --git a/nptl/tst-cancel4.c b/nptl/tst-cancel4.c
> index 9ffd5d1..04f9282 100644
> --- a/nptl/tst-cancel4.c
> +++ b/nptl/tst-cancel4.c
> @@ -83,7 +83,7 @@ static pthread_barrier_t b2;
> # define IPC_ADDVAL 0
> #endif
>
Since this hit us, could you document the reason for the buffer size?
othewise fine,
Andreas
> -#define WRITE_BUFFER_SIZE 4096
> +#define WRITE_BUFFER_SIZE 16384
>
> /* Cleanup handling test. */
> static int cl_called;
>
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126