This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix -Wundef warnings for _ABI* on MIPS
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 21 Mar 2014 13:04:07 -0700 (PDT)
- Subject: Re: Fix -Wundef warnings for _ABI* on MIPS
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1403211822020 dot 4557 at digraph dot polyomino dot org dot uk>
I would recommend two things:
1. Give sgidefs.h clear comments that its mandate is to define only
implementation-space macro names so that anyone considering modifying
the file knows that must be kept name space clean so that it continues
to be appropriate to include it in any installed header. (While you're
there you could clean up the existing comments to match our style.)
2. Write:
#include <sgidefs.h> /* Defines _MIPS_*, _ABI*. */
just so it's obvious what the #include is there for, since it
has a name so far from obviously related to its purpose.