This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Don't use -Wno-uninitialized in math/

From: Chris Metcalf <cmetcalf at ezchip dot com>
To: <sellcey at imgtec dot com>, Roland McGrath <roland at hack dot frob dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>
Date: Thu, 27 Aug 2015 13:20:18 -0400
Subject: Re: Don't use -Wno-uninitialized in math/
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=cmetcalf at ezchip dot com;
References: <alpine dot DEB dot 2 dot 10 dot 1508201800380 dot 30940 at digraph dot polyomino dot org dot uk> <1440173079 dot 23512 dot 36 dot camel at ubuntu-sellcey> <55DE1A17 dot 5060706 at ezchip dot com> <alpine dot DEB dot 2 dot 10 dot 1508262116390 dot 6767 at digraph dot polyomino dot org dot uk> <1440627171 dot 14154 dot 13 dot camel at ubuntu-sellcey> <alpine dot DEB dot 2 dot 10 dot 1508262214260 dot 6767 at digraph dot polyomino dot org dot uk> <1440628824 dot 14154 dot 16 dot camel at ubuntu-sellcey> <20150826225743 dot 1A8782C39E0 at topped-with-meat dot com> <1440630636 dot 14154 dot 19 dot camel at ubuntu-sellcey> <20150826231308 dot 53F3C2C39E0 at topped-with-meat dot com> <1440631106 dot 14154 dot 20 dot camel at ubuntu-sellcey>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:23

On 08/26/2015 07:18 PM, Steve Ellcey wrote:

On Wed, 2015-08-26 at 16:13 -0700, Roland McGrath wrote:

OK, here is a new version of the patch including sys/cdefs.h instead of
features.h and moving the comments about the DIAG up with the actual

You forgot to update the log entry.

Argh, you are right.


2015-08-26  Steve Ellcey  <sellcey@imgtec.com>

	* soft-fp/fmasf4.c: Add include of sys/cdefs.h.
	Move DIAG_PUSH_NEEDS_COMMENT, DIAG_IGNORE_NEEDS_COMMENT to front of
	file, move DIAG_POP_NEEDS_COMMENT to end of file.
	* soft-fp/fmadf4.c: Ditto.
	* soft-fp/fmatf4.c: Ditto.


This fixes the build failure for tilegx with gcc 4.8.2 as well.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

Follow-Ups:
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey

References:
- Don't use -Wno-uninitialized in math/
  - From: Joseph Myers
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey
- Re: Don't use -Wno-uninitialized in math/
  - From: Chris Metcalf
- Re: Don't use -Wno-uninitialized in math/
  - From: Joseph Myers
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey
- Re: Don't use -Wno-uninitialized in math/
  - From: Joseph Myers
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey
- Re: Don't use -Wno-uninitialized in math/
  - From: Roland McGrath
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey
- Re: Don't use -Wno-uninitialized in math/
  - From: Roland McGrath
- Re: Don't use -Wno-uninitialized in math/
  - From: Steve Ellcey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]