This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Synchronize <sys/personality.h> with kernel headers
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Fri, 25 Mar 2016 12:54:19 -0300
- Subject: Re: [PATCH] Synchronize <sys/personality.h> with kernel headers
- Authentication-results: sourceware.org; auth=none
- References: <1458844558-15949-1-git-send-email-aurelien at aurel32 dot net>
LGTM. I wonder if you should include PER_CLEAR_ON_SETID as well, thoughts?
On 24-03-2016 15:35, Aurelien Jarno wrote:
> <sys/personality.h> is out of sync with kernel headers, missing the
> UNAME26, FDPIC_FUNCPTRS and PER_LINUX_FDPIC entries. Fix that.
>
> Changelog:
> * sysdeps/unix/sysv/linux/sys/personality.h (UNAME26, FDPIC_FUNCPTRS,
> PER_LINUX_FDPIC): Add.
> ---
> ChangeLog | 5 +++++
> sysdeps/unix/sysv/linux/sys/personality.h | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 1739a0f..6ec0ca1 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2016-03-24 Aurelien Jarno <aurelien@aurel32.net>
> +
> + * sysdeps/unix/sysv/linux/sys/personality.h (UNAME26, FDPIC_FUNCPTRS,
> + PER_LINUX_FDPIC): Add.
> +
> 2016-03-24 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #19848]
> diff --git a/sysdeps/unix/sysv/linux/sys/personality.h b/sysdeps/unix/sysv/linux/sys/personality.h
> index af2ece6..ad2258f 100644
> --- a/sysdeps/unix/sysv/linux/sys/personality.h
> +++ b/sysdeps/unix/sysv/linux/sys/personality.h
> @@ -26,7 +26,9 @@
> These occupy the top three bytes. */
> enum
> {
> + UNAME26 = 0x0020000,
> ADDR_NO_RANDOMIZE = 0x0040000,
> + FDPIC_FUNCPTRS = 0x0080000,
> MMAP_PAGE_ZERO = 0x0100000,
> ADDR_COMPAT_LAYOUT = 0x0200000,
> READ_IMPLIES_EXEC = 0x0400000,
> @@ -45,6 +47,7 @@ enum
> {
> PER_LINUX = 0x0000,
> PER_LINUX_32BIT = 0x0000 | ADDR_LIMIT_32BIT,
> + PER_LINUX_FDPIC = 0x0000 | FDPIC_FUNCPTRS,
> PER_SVR4 = 0x0001 | STICKY_TIMEOUTS | MMAP_PAGE_ZERO,
> PER_SVR3 = 0x0002 | STICKY_TIMEOUTS | SHORT_INODE,
> PER_SCOSVR3 = 0x0003 | STICKY_TIMEOUTS | WHOLE_SECONDS | SHORT_INODE,
>