Re: [PATCH] test-skeleton: redirect stderr to stdout

[Mike Frysinger <vapier at gentoo dot org>]

On 16 Jun 2016 08:50, Zack Weinberg wrote:
> On Thu, Jun 16, 2016 at 12:48 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > +  fclose (stderr);
> > +  dup2 (STDOUT_FILENO, STDERR_FILENO);
> > +  stderr = fdopen (STDERR_FILENO, "w");
> 
> Wouldn't the dup2 be sufficient by itself?  And then you don't have to
> worry about allocation failure in fdopen.

i don't think there's any guarantee of the stdio handles being sane when
the fd is changed underneath them.  if the standards say otherwise, or
we have a guarantee in glibc, then sure.

> Also a setbuf(stderr, NULL) is probably appropriate.

initially it's not needed [1], but since i'm recreating it, yeah, i'll
have to reset the buffer behavior.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/stderr.html
-mike

Attachment: signature.asc
Description: Digital signature