This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
- From: Cyril Hrubis <chrubis at suse dot cz>
- To: "Michael Kerrisk (man-pages)" <mtk dot manpages at gmail dot com>
- Cc: Jeff Layton <jlayton at redhat dot com>, Florian Weimer <fweimer at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org, linux-fsdevel at vger dot kernel dot org, Carlos O'Donell <carlos at redhat dot com>, Yuriy Kolerov <Yuriy dot Kolerov at synopsys dot com>
- Date: Mon, 14 Nov 2016 14:45:10 +0100
- Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64
- Authentication-results: sourceware.org; auth=none
- References: <1471464343.3196.125.camel@redhat.com> <20160817203746.GF21655@vapier.lan> <1471467478.3196.143.camel@redhat.com> <20160817213522.GG21655@vapier.lan> <1471470526.3196.153.camel@redhat.com> <8e1a972a-7966-139b-9d75-6d3a847a1be8@redhat.com> <20160823110343.GA4962@rei.suse.cz> <1471952179.13027.3.camel@redhat.com> <20160823113830.GB4962@rei.suse.cz> <8acbfa50-516f-d402-928f-9a391610557d@gmail.com>
Hi!
> >> To be clear, that approach was NAK'ed by Christoph (and I think that's
> >> a good thing, actually -- one more nail in the non-LFS coffin). I think
> >> what we want merged into glibc is this patch that I sent late on
> >> Thursday:
> >>
> >> [glibc PATCHv2] fcntl: don't define OFD lock constants for 32-bit builds with small file offsets
> >>
> >> We'll also need your patch to the fcntl(2) manpage as well, but that's
> >> a separate problem.
> >
> > Hmm, the patch for man-pages should be updated as well. We need
> > somethign as:
> >
> > ...
> > This lock type is Linux-specific, and available since Linux 3.15.
> > On 32bit platform _FILE_OFFSET_BITS must defined to 64 (before including
> > any header files) to make these locks available.
> > ...
> >
> > Michael should I send updated patch or will you take care of this?
>
> I can do it, or you can. At the moment, I'm just holding off until I
> see what is accepted into glibc.
Ping.
Is there any resolve for this?
--
Cyril Hrubis
chrubis@suse.cz